Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Repetier-Server Component #21658

Merged
merged 38 commits into from May 29, 2019

Conversation

Projects
None yet
6 participants
@MTrab
Copy link
Contributor

commented Mar 4, 2019

Description:

Adding Repetier-Server component providing sensors for your Repetier-Server devices

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8823

Example entry for configuration.yaml (if applicable):

# Example configuration.yaml entry
repetier:
  - host: REPETIER_HOST
    api_key: YOUR_API_KEY

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated

@MTrab MTrab referenced this pull request Mar 4, 2019

Closed

Add Repetier-Server component documentation #8823

2 of 2 tasks complete
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated

@MTrab MTrab force-pushed the MTrab:repetier branch from 5c0b3c2 to 2d0b9a8 Mar 21, 2019

Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated

@MTrab MTrab force-pushed the MTrab:repetier branch from 65e1c72 to 17c4f75 Mar 28, 2019

Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated

@MTrab MTrab force-pushed the MTrab:repetier branch from 3e01331 to 25bba53 Apr 6, 2019

@MTrab

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

@MartinHjelmare do we still have problems with CI?

It's complaining about a missing manifest.json file?!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

No, CI is working now. Please add a manifest.json file. Look at other existing integrations for examples.

Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated

@MTrab MTrab changed the title Add Repetier-Server Component WIP: Add Repetier-Server Component Apr 10, 2019

@MTrab

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

homeassistant/components/repetier/init.py:79:19: E1101: Instance of 'Repetier' has no 'getprinters' member; maybe 'getPrinters'?

Erhm?! pyrepetier have class Repetier and have getprinters() defined. Why do I get this error?

Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/repetier/sensor.py Outdated
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

I've pushed my suggestion to your branch. Please check it out if you think it's ok. If it looks ok, please test it.

@home-assistant home-assistant deleted a comment from houndci-bot Apr 24, 2019

@home-assistant home-assistant deleted a comment from houndci-bot Apr 24, 2019

@home-assistant home-assistant deleted a comment from houndci-bot Apr 24, 2019

@home-assistant home-assistant deleted a comment from houndci-bot Apr 24, 2019

@home-assistant home-assistant deleted a comment from houndci-bot Apr 24, 2019

@MTrab

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

Still trying to crack this nut.

discovery.load_platform = load_platform in __init__.py?
Does this mean I have to move the content of the setup function in __init__.py to a new function, and call that?

@MTrab MTrab force-pushed the MTrab:repetier branch from c9f827f to 9cb0ca8 May 17, 2019

@MTrab MTrab changed the title WIP: Add Repetier-Server Component Add Repetier-Server Component May 23, 2019

@MartinHjelmare
Copy link
Member

left a comment

Nice! Just one simplification I found.

Show resolved Hide resolved homeassistant/components/repetier/__init__.py Outdated
@MartinHjelmare
Copy link
Member

left a comment

Awesome!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented May 25, 2019

I think we can merge when build passes. Do you agree?

@MTrab

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

Agreed - a whole new set of ideas for improvement are forming in my head, but lets merge this as it is now.
It's really useful for sensor data, as is. Next step must be controlling temperatures and so on :)

@MTrab

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

And thank you VERY much for you help - really learned alot regarding Python programming 👍

@cgarwood

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Fixed a merge conflict in .coveragerc - just waiting on builds to complete/pass again

@MTrab

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

@cgarwood - I think something went wrong ;)

@cgarwood

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Just timed out, build re-ran and passed. Good to merge 👍

@cgarwood cgarwood merged commit 85dfea1 into home-assistant:dev May 29, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing f2033c4...3876864
Details
codecov/project 94.16% (target 90%)
Details

@balloob balloob added new-integration and removed new-platform labels Jun 3, 2019

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.