Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Serialize amcrest snapshot commands and bump PyPI package to 1.2.4 #21664
Attempting to send a snapshot command when a previous one hasn't finished will result in warnings and/or errors. This can happen when the camera picture is clicked on in the frontend, resulting in the thread that updates the thumbnail in the background every 10 seconds to sometimes collide with the thread that updates the large picture in the foreground quickly. An automation that calls the camera.snapshot service in yet another thread can make the situation worse. Fix by adding a thread lock to serialize snapshot commands. Also bump the amcrest package to 1.2.4 which fixes error handling in the command method and improves performance by reusing requests sessions.
Related issue (if applicable): None
Pull request in home-assistant.io with documentation (if applicable): None
Example entry for
Mar 5, 2019
Yes, I know. It was a misunderstanding between me and the maintainer. Working on a new PR now to change to 1.2.5.…
On Wed, Mar 6, 2019 at 3:42 PM Markus Jankowski ***@***.***> wrote: Hi, there is no 1.2.4 in pypi. Just 1.2.3 and 1.2.5. BR Markus — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21664 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AiWM2XAK93IxvzN9h7Q_naPD6d-B1uClks5vUDY1gaJpZM4bdRoo> .