Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump teslajsonpy to 0.0.24 #21675

Merged
merged 2 commits into from Mar 5, 2019

Conversation

Projects
None yet
5 participants
@alandtse
Copy link
Contributor

commented Mar 5, 2019

Description:

This updates to the newer version of teslajsonpy which now will try to wake_up the Tesla if it detects the Tesla is asleep when issuing commands. It will also retry commands to address a situation where the Tesla is awake but unable to issue the command internally.

NOTE: This version of teslajsonpy will not attempt to wake sleeping Tesla vehicles for standard updates to conserve battery. This means HA state will not update until the car is detected as awake.
The prior release would potentially wake vehicles resulting in potential phantom drain particularly for users who were not charging daily. In addition, Tesla implements certain deep sleep algorithms which would be prevented by constant updates. We will monitor the issues to see if this results in any major complaints from users to see if we need to expose a manual wake_up service.

Related issue (if applicable): fixes #17272

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Not applicable as no functional changes to component code.

Example entry for configuration.yaml (if applicable):

Not applicable as no functional changes to component code.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:
Not applicable as no functional changes to component code.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

alandtse added some commits Mar 5, 2019

@balloob balloob merged commit dbb9204 into home-assistant:dev Mar 5, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 92.759%
Details

@ghost ghost removed the in progress label Mar 5, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

@boberthepker

This comment has been minimized.

Copy link

commented Apr 8, 2019

This is sooo much better! Thank you for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.