Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Freebox switch platform #21710

Merged
merged 12 commits into from Mar 23, 2019

Conversation

Projects
None yet
4 participants
@SNoof85
Copy link
Contributor

SNoof85 commented Mar 6, 2019

Description:

Since the old PR was going crazy with a lot of versions between my local branch and the actual HA branch. This PR is up to date.

This will add a switch to control WiFi on Freebox routers.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8843

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

SNoof85 added some commits Mar 6, 2019

@SNoof85

This comment has been minimized.

Copy link
Contributor Author

SNoof85 commented Mar 14, 2019

Bumped aiofreepybox to newest version even the changes made to the package are not needed for this switch implementation. I also bumped the API verison to talk to the router because v1 can be buggy sometimes.
This PR is now ready to be merged if there's no requests from team o/

@amelchio
Copy link
Contributor

amelchio left a comment

Looks good 👍

Show resolved Hide resolved homeassistant/components/freebox/switch.py Outdated
@dgomes

dgomes approved these changes Mar 21, 2019

SNoof85 added some commits Mar 22, 2019

@amelchio amelchio merged commit d81df1f into home-assistant:dev Mar 23, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.9%) to 93.673%
Details

@wafflebot wafflebot bot removed the in progress label Mar 23, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Mar 27, 2019

Merge branch 'dev' into current
* dev: (99 commits)
  show which component is causing translation errors (home-assistant#22340)
  fix where PLATFORM_SCHEMA gets pulled from (home-assistant#22334)
  Consolidate more platforms (home-assistant#22308)
  Update file header (home-assistant#22318)
  Remove occupancy as it is not available in API (home-assistant#22320)
  Google Assistant: Add camera stream trait (home-assistant#22278)
  Add Freebox switch platform (home-assistant#21710)
  Add homematicip cloud connection quality related attributes (home-assistant#21990)
  Update abbreviation (home-assistant#22317)
  Upgrade py-cpuinfo to 5.0.0 (home-assistant#22287)
  Upgrade pylast to 3.1.0 (home-assistant#22302)
  Fix for embedded MQTT server configuration (home-assistant#22305)
  Switch from using Google Maps API for elevation to Open Elevation API (home-assistant#22306)
  Update srpenergy library (home-assistant#22307)
  Sort code owners alphabetically (home-assistant#22304)
  Update trait to support auto without ranges. (home-assistant#21847)
  Fix Prometheus casting issues (home-assistant#22282)
  Add sort by config and tests for Reddit integration (home-assistant#22081)
  Fix progress for Plex media_players (home-assistant#22224)
  Fixing the api_streams sensor (home-assistant#22200)
  ...

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.