Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom holidays to workday sensor #21718

Merged
merged 10 commits into from Mar 10, 2019

Conversation

Projects
None yet
4 participants
@epleypa
Copy link
Contributor

commented Mar 6, 2019

Description:

Add custom holidays to workday sensor (such as company, personal holidays, or vacations)

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8887

Example entry for configuration.yaml (if applicable):

binary_sensor:
- platform: workday
  country: US
  workdays: [mon,tue,wed,thu,fri]
  excludes: [sat,sun,holiday]
  add_holidays: ['2018-12-26','2018-12-27','2018-12-28','2018-12-31']

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

epleypa added some commits Mar 6, 2019

epleypa added some commits Mar 6, 2019

epleypa added some commits Mar 9, 2019

Show resolved Hide resolved homeassistant/components/binary_sensor/workday.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/workday.py Outdated

@ghost ghost assigned fabaff Mar 10, 2019

@fabaff

fabaff approved these changes Mar 10, 2019

@fabaff fabaff merged commit c888e65 into home-assistant:dev Mar 10, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 92.724%
Details

@ghost ghost removed the in progress label Mar 10, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.