Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change amcrest camera_image to async #21720

merged 1 commit into from Mar 7, 2019


None yet
4 participants
Copy link

pnbruckner commented Mar 6, 2019


Per discussion in #21664, change AmcresCam's camera_image method to async so that an asyncio lock can be used instead of a threading lock.

Also bump amcrest package version to 1.2.5 to avoid a potential threading issue with requests.Session. (Also, due to a miscommunication, amcrest 1.2.4 was deleted from prematurely.)

Related issue (if applicable): None

Pull request in with documentation (if applicable): None

Example entry for configuration.yaml (if applicable):

No change in configuration required.


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/
Change amcrest camera_image to async
Change AmcrestCam method camera_image to async so asyncio lock can be used instead of a threading lock. Bump amcrest package to 1.2.5.

This comment has been minimized.

Copy link
Contributor Author

pnbruckner commented Mar 6, 2019

@amelchio, here is the new PR to change AmcrestCam.camera_image to async.

Copy link

amelchio left a comment

Thanks for resolving this so quickly 🎉


This comment has been minimized.

Copy link

balloob commented Mar 7, 2019

Should this be tagged for a hot fix?

Never mind, only merged 2 days ago.

@balloob balloob merged commit 5616505 into home-assistant:dev Mar 7, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
coverage/coveralls Coverage decreased (-0.002%) to 92.756%

@wafflebot wafflebot bot removed the in progress label Mar 7, 2019

@pnbruckner pnbruckner deleted the pnbruckner:amcrest-asyncio branch Mar 7, 2019

@balloob balloob referenced this pull request Mar 20, 2019


0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.