Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tplink - catch SmartDeviceException on is_dimmable call #21726

Merged
merged 3 commits into from Mar 7, 2019

Conversation

Projects
None yet
6 participants
@ljmerza
Copy link
Contributor

commented Mar 7, 2019

Description:

is_dimmable can raise SmartDeviceException if unable to connect to device

Related issue (if applicable): fixes #
Fix for #21725

@ljmerza ljmerza closed this Mar 7, 2019

@ljmerza ljmerza reopened this Mar 7, 2019

@ghost ghost added in progress and removed in progress labels Mar 7, 2019

@rytilahti
Copy link
Contributor

left a comment

Looks straightforward to me, thanks! The next major release should change the behavior to avoid I/O on device properties and allow cleaning up the component code accordingly, the upstream issue: GadgetReactor/pyHS100#164

This can be merged after the travis passes.

@rytilahti rytilahti merged commit 9c70b00 into home-assistant:dev Mar 7, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 92.751%
Details

@ghost ghost removed the in progress label Mar 7, 2019

@amelchio

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

Should this be tagged for 0.89.1?

@awarecan

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

Looks like 0.89.1 already out? @balloob

@ljmerza ljmerza deleted the ljmerza:tplink-exception branch Mar 8, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.