Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing SUPPORT_VOLUME_SET flag to webos media_player #21766

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
4 participants
@dthulke
Copy link
Contributor

dthulke commented Mar 7, 2019

Description:

The SUPPORT_VOLUME_SET flag was missing in the webos media player though it supports the necessary functionality (set and get volume_level). The flag was already missing in the first version of the platform.

This issue came up in issue #21481 but was also mentioned in the forum:
https://community.home-assistant.io/t/control-lg-tv-volume-with-google-home/67531
https://community.home-assistant.io/t/setting-up-google-actions-for-assistant/29889/658

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.89.1 milestone Mar 8, 2019

@balloob balloob merged commit 2fb9783 into home-assistant:dev Mar 8, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.755%
Details

@wafflebot wafflebot bot removed the in progress label Mar 8, 2019

balloob added a commit that referenced this pull request Mar 8, 2019

@balloob balloob referenced this pull request Mar 8, 2019

Merged

0.89.1 #21778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.