Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add availability and next run datetime to RainMachine switches #21786

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@bachya
Copy link
Contributor

commented Mar 8, 2019

Description:

This PR:

  1. adds a next_run attribute (denoting the next run date/time) to program switches.
  2. shows all programs and zones – inactive or active – by default. This is done in order to complement the enable/disable services proposed in #21785; previously, inactive programs/zones would not be loaded, rendering those services useless.

Note that this does not require #21785 to be merged first; either order is fine.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

rainmachine:
  controllers:
    - ip_address: 192.168.1.101
      password: !secret rainmachine_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
@cgtobi

cgtobi approved these changes Mar 13, 2019

Copy link
Collaborator

left a comment

LGTM

@bachya bachya merged commit 897862f into home-assistant:dev Mar 13, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.753%
Details

@ghost ghost removed the in progress label Mar 13, 2019

@bachya bachya deleted the bachya:rainmachine-updates-2 branch Mar 13, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.