Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove occupancy, as it is not available at this level in the iRail api #21810

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
4 participants
@nudded
Copy link
Contributor

commented Mar 8, 2019

Description:

Related issue (if applicable): References #20744

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@nudded

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

This solves #20744 (comment) , as the data is simply not present in the upstream API provider. (iRail)

@fabaff

fabaff approved these changes Mar 8, 2019

@fabaff fabaff merged commit a0e8543 into home-assistant:dev Mar 8, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.755%
Details

@ghost ghost removed the in progress label Mar 8, 2019

@nudded nudded deleted the nudded:fix-nmbs-sensor branch Mar 9, 2019

@thibmaek

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

Wow! Thanks! I was going to pick this up this weekend @nudded but I'm glad to see you did that already!

Seems like iRail has removed this in their API, it was def. available before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.