Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add area permission check #21835

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@balloob
Copy link
Member

commented Mar 9, 2019

Description:

Allow checking entity permissions based on area IDs. Uses entity registry to find device, device registry to find area id.

Removed all the repeating code and made a small compile utility.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/developers.home-assistant#195

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Mar 9, 2019

@ghost ghost assigned balloob Mar 9, 2019

@ghost ghost added the in progress label Mar 9, 2019

@balloob balloob referenced this pull request Mar 9, 2019

Merged

Update auth_permissions.md #195

@balloob balloob merged commit 4f5446f into dev Mar 11, 2019

10 checks passed

Hound No violations found. Woof!
Python 3.5 - lints Python 3.5 - lints
Details
Python 3.5 - tests Python 3.5 - tests
Details
Python 3.6 - tests Python 3.6 - tests
Details
Python 3.7 - tests Python 3.7 - tests
Details
Pyton 3.5 - typing Pyton 3.5 - typing
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.007%) to 92.737%
Details

@ghost ghost removed the in progress label Mar 11, 2019

@delete-merged-branch delete-merged-branch bot deleted the add-area-permission branch Mar 11, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.