Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SmartThings sensor support for Three Axis #21841

Conversation

Projects
None yet
3 participants
@andrewsayre
Copy link
Member

commented Mar 9, 2019

Description:

Adds support for the Three Axis capability to the SmartThings sensor platform. The value is represented as three discrete sensors for each coordinate (x, y, z).

Related issue (if applicable): fixes #21781

Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#8879

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@andrewsayre andrewsayre force-pushed the andrewsayre:enhancement-smartthings-sensor-threeaxis branch from 2ca6e3b to dc7b959 Mar 9, 2019

@MartinHjelmare
Copy link
Member

left a comment

Nice!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

Can be merged when build passes.

@andrewsayre

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

Test failure is the unrelated flaky test. Proceeding to merge.

@andrewsayre andrewsayre merged commit 5ace55e into home-assistant:dev Mar 10, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA

@ghost ghost removed the in progress label Mar 10, 2019

@andrewsayre andrewsayre deleted the andrewsayre:enhancement-smartthings-sensor-threeaxis branch Mar 10, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.