Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle on/off through TemperatureSetting trait #21842

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
3 participants
@Swamp-Ig
Copy link
Contributor

commented Mar 9, 2019

Description:

For climate(in HA)/thermostat (in GA), the reccomended traits are the TemperatureSetting trait only, and not the OnOff trait.

GA actually completely ignores the OnOff trait, and will process "turn on " and "turn off " commands only through the TemperatureSetting trait.

I have fixed this by removing climate from OnOff, and passing on turn on / off properly (by calling the turn_on and turn_off services).

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Mar 9, 2019

@Swamp-Ig Swamp-Ig force-pushed the Swamp-Ig:climate-on-off branch from 14da1ed to 8588d16 Mar 9, 2019

@fabaff fabaff changed the title Handle on/off through TemperatrureSetting trait. Handle on/off through TemperatureSetting trait Mar 10, 2019

@Swamp-Ig Swamp-Ig force-pushed the Swamp-Ig:climate-on-off branch from 8588d16 to 43c25ae Mar 19, 2019

@ghost ghost assigned Swamp-Ig Mar 19, 2019

@Swamp-Ig Swamp-Ig requested a review from balloob Mar 19, 2019

@balloob balloob merged commit 81bb928 into home-assistant:dev Mar 21, 2019

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
coverage/coveralls Coverage decreased (-0.004%) to 93.679%
Details

@ghost ghost removed the in progress label Mar 21, 2019

@Swamp-Ig Swamp-Ig deleted the Swamp-Ig:climate-on-off branch Mar 23, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.