Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with auto(HA) = heatcool(GA) when the device doesn't support ranges #21847

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
3 participants
@Swamp-Ig
Copy link
Contributor

commented Mar 9, 2019

Description:

The TemperatureSetting trait on GA has an different interpretation of what 'auto' means than HA, and it always uses a temperature range.

In HA, some climate devices have an auto mode where a range is set, and some have a single value. This PR fixes the GA trait so that the correct mode will be returned depending on the support flags set in the component.

I had a quick look through the HA climate components, the components affected by the issue are:

  • coolmaster
  • daikin
  • demo (depending on how configured)
  • ephember
  • radiotherm
  • sensibo
  • tuya

venstar seems to be the only one that I could see that supported ranges that hasn't been moved into it's own component subdir (I didn't look through all the component subdirs). The upshot is the majority won't work without this bugfix.

Related issue (if applicable): fixes #19815

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Mar 9, 2019

@Swamp-Ig Swamp-Ig changed the title WIP: Manage heatcool / auto mode correctly in GA WIP: Manage auto=heatcool correctly in GA when the device doesn't support ranges Mar 9, 2019

@Swamp-Ig Swamp-Ig force-pushed the Swamp-Ig:climate-auto branch from 2c74e96 to fd408c9 Mar 9, 2019

@Swamp-Ig Swamp-Ig changed the title WIP: Manage auto=heatcool correctly in GA when the device doesn't support ranges Fix issue with auto(HA) = heatcool(GA) when the device doesn't support ranges Mar 9, 2019

@Swamp-Ig Swamp-Ig force-pushed the Swamp-Ig:climate-auto branch 3 times, most recently from 71ae8f1 to 245e6e8 Mar 9, 2019

@Swamp-Ig Swamp-Ig force-pushed the Swamp-Ig:climate-auto branch from 245e6e8 to b22714d Mar 19, 2019

@ghost ghost assigned Swamp-Ig Mar 19, 2019

@Swamp-Ig Swamp-Ig force-pushed the Swamp-Ig:climate-auto branch from b22714d to 1792a9f Mar 19, 2019

@Swamp-Ig Swamp-Ig requested a review from balloob Mar 19, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Can you rebase this PR

@Swamp-Ig Swamp-Ig force-pushed the Swamp-Ig:climate-auto branch from 1792a9f to 80377a0 Mar 22, 2019

@Swamp-Ig

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

@balloob rebased, tox will succeed because it did before and there's nothing new.

@balloob balloob merged commit ecabf92 into home-assistant:dev Mar 22, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 93.674%
Details
@balloob

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Nice!

@ghost ghost removed the in progress label Mar 22, 2019

@Swamp-Ig Swamp-Ig deleted the Swamp-Ig:climate-auto branch Mar 23, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Mar 27, 2019

Merge branch 'dev' into current
* dev: (99 commits)
  show which component is causing translation errors (home-assistant#22340)
  fix where PLATFORM_SCHEMA gets pulled from (home-assistant#22334)
  Consolidate more platforms (home-assistant#22308)
  Update file header (home-assistant#22318)
  Remove occupancy as it is not available in API (home-assistant#22320)
  Google Assistant: Add camera stream trait (home-assistant#22278)
  Add Freebox switch platform (home-assistant#21710)
  Add homematicip cloud connection quality related attributes (home-assistant#21990)
  Update abbreviation (home-assistant#22317)
  Upgrade py-cpuinfo to 5.0.0 (home-assistant#22287)
  Upgrade pylast to 3.1.0 (home-assistant#22302)
  Fix for embedded MQTT server configuration (home-assistant#22305)
  Switch from using Google Maps API for elevation to Open Elevation API (home-assistant#22306)
  Update srpenergy library (home-assistant#22307)
  Sort code owners alphabetically (home-assistant#22304)
  Update trait to support auto without ranges. (home-assistant#21847)
  Fix Prometheus casting issues (home-assistant#22282)
  Add sort by config and tests for Reddit integration (home-assistant#22081)
  Fix progress for Plex media_players (home-assistant#22224)
  Fixing the api_streams sensor (home-assistant#22200)
  ...

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.