Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ephember doing http call from property #21855

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
3 participants
@ttroy50
Copy link
Contributor

commented Mar 9, 2019

Description:

This should fix the warning related to #4210 for the ephember platform

Related issue (if applicable): #4210

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Mar 9, 2019

@fabaff fabaff changed the title fix ephember doing http call from property Fix ephember doing http call from property Mar 9, 2019

@@ -117,7 +117,8 @@ def device_state_attributes(self):
@property
def current_operation(self):
"""Return current operation ie. heat, cool, idle."""
mode = self._ember.get_zone_mode(self._zone_name)
from pyephember.pyephember import ZoneMode
mode = ZoneMode(self._zone['mode'])
return self.map_mode_eph_hass(mode)

This comment has been minimized.

Copy link
@pvizeli

pvizeli Mar 12, 2019

Member

For the next PR. If you call a function only once, you don't need it and can save the function frame. The map_mode_eph_hass can be cleanup.

@pvizeli pvizeli merged commit cc34ee5 into home-assistant:dev Mar 12, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 92.725%
Details

@ghost ghost removed the in progress label Mar 12, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.