Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing code_required check in async_alarm_arm_night #21858

Merged
merged 2 commits into from Mar 10, 2019

Conversation

Projects
None yet
3 participants
@ToRvaLDz
Copy link
Contributor

commented Mar 9, 2019

Description:

Fix missing code_required check in async_alarm_arm_night in PR #19558

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ToRvaLDz ToRvaLDz requested a review from home-assistant/core as a code owner Mar 9, 2019

@ghost ghost added the in progress label Mar 9, 2019

@emontnemery

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2019

Looks good, can you please add tests also?

@ToRvaLDz

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

@emontnemery test added ;)

@emontnemery
Copy link
Contributor

left a comment

LGTM

@emontnemery emontnemery merged commit 05333f6 into home-assistant:dev Mar 10, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0005%) to 92.723%
Details

@ghost ghost removed the in progress label Mar 10, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.