Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enigma2 based on review comments #21890

Merged
merged 3 commits into from Mar 11, 2019

Conversation

Projects
None yet
5 participants
@fbradyirl
Copy link
Collaborator

commented Mar 10, 2019

Description:

There were some extra comments rasied by @MartinHjelmare after my Enigma2 component got merged, so this PR is to address those.

  • Bumping netdisco to 2.4.0 since this includes Enigma2 discovery in PR #21914. Thanks @balloob for the bump on that.

Related issue (if applicable): fixes #21271

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@MartinHjelmare MartinHjelmare changed the title Updates based on review comments Update enigma2 based on review comments Mar 10, 2019

@MartinHjelmare
Copy link
Member

left a comment

Great!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

Can be merged when build passes.

@amelchio amelchio merged commit 85dc5fe into home-assistant:dev Mar 11, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 92.741%
Details

@ghost ghost removed the in progress label Mar 11, 2019

@fbradyirl fbradyirl deleted the fbradyirl:e2Fixes branch Mar 11, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

@jjeremia

This comment has been minimized.

Copy link

commented Mar 24, 2019

I get error:
Exception: ('OpenWebIf responded with a 404 from %s', 'http://192.168.1.103:80/api/about')
Looks like I need to use /web/about instead og /api/about (ref.: https://wiki.tuxbox-neutrino.org/wiki/Enigma2:WebInterface)
I'm on DM8000 with Newnigma2.
Maybe this could be added as a config section?

@fbradyirl

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 24, 2019

Looks like you don’t have OpenWebIf installed. You have Webif which is xml based and not supported by this component.

If you need to discuss further please open a new issue.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.