Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service description for services. #21897

Merged
merged 2 commits into from Mar 17, 2019

Conversation

Projects
None yet
4 participants
@cgtobi
Copy link
Collaborator

cgtobi commented Mar 10, 2019

Description:

Add the service description for the google calendar services.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Mar 10, 2019

@cgtobi cgtobi closed this Mar 10, 2019

@wafflebot wafflebot bot removed the in progress label Mar 10, 2019

@cgtobi cgtobi reopened this Mar 10, 2019

@wafflebot wafflebot bot added the in progress label Mar 10, 2019

@cgtobi cgtobi marked this pull request as ready for review Mar 12, 2019

@fabaff

fabaff approved these changes Mar 17, 2019

@fabaff fabaff merged commit ba923d2 into home-assistant:dev Mar 17, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on gcal_missing_services_yaml at 92.768%
Details

@wafflebot wafflebot bot removed the in progress label Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.