Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomeKit controller config flow fixes #21898

Merged

Conversation

Projects
None yet
3 participants
@Jc2k
Copy link
Contributor

commented Mar 10, 2019

Description:

This PR fixes a couple of issues I identified in my earlier PR (#21564):

  • As part of code review we tried to use vol.Strip - but it turns out this can't be serialized so can't be used in config flow, so I have backed out that change.

  • At some point whilst splitting off the PR from the branch it originated in I managed to revert to an older + broken strings.json. I noticed immediately when preparing the next stage of the config flow and thought best to patch it ASAP to avoid headache for translators.

Related issue (if applicable): #21564

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@Jc2k

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

Outstanding comments resolved.

@MartinHjelmare
Copy link
Member

left a comment

Good!

@MartinHjelmare MartinHjelmare merged commit b0d55d1 into home-assistant:dev Mar 11, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 92.73%
Details

@ghost ghost removed the in progress label Mar 11, 2019

@Jc2k Jc2k deleted the Jc2k:homekit_controller_cfg_flow_fixes branch Mar 11, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.