Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add as_timestamp() to Jinja filters #21910

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@rbdixon
Copy link
Contributor

commented Mar 10, 2019

Description:

This is helpful for writing templates that use sensors, such as the
envisalink, which return a string "last_tripped_time" attribute.

Example:

{{ [now()] | map('as_timestamp') | list }}

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8905

Checklist:

  • [x ] The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Add as_timestamp() to Jinja filters.
This is helpful for writing templates that use sensors, such as the
envisalink, which return a string "last_tripped_time" attribute.

@rbdixon rbdixon requested a review from home-assistant/core as a code owner Mar 10, 2019

@ghost ghost added the in progress label Mar 10, 2019

@fabaff

fabaff approved these changes Mar 11, 2019

@fabaff fabaff changed the title Add as_timestamp() to Jinja filters. Add as_timestamp() to Jinja filters Mar 11, 2019

@fabaff fabaff merged commit 9ab543a into home-assistant:dev Mar 11, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0001%) to 92.725%
Details

@ghost ghost removed the in progress label Mar 11, 2019

@rbdixon rbdixon deleted the rbdixon:as_timestamp_filter branch Mar 11, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.