Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed from nanoleaf_aurora to nanoleaf #21913

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@Oro
Copy link
Contributor

Oro commented Mar 10, 2019

Nanoleaf component now supports both nanoleaf lights, Aurora and Canvas
Changed the dependency to pynanoleaf (disclaimer: I am currently the maintainer of this dependency and it is quite new), nanoleaf does not seem to be maintained anymore. The nanoleaf module does not support Canvas unfortunately

Note that this is a BREAKING change from configuration for nanoleaf_aurora to nanoleaf
If you have any pointer as to how to make this easier for users (maybe accept both, nanoleaf_aurora and nanoleaf?) please do tell!

Description:

Related issue (if applicable): None
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8906

Example entry for configuration.yaml (if applicable):

light:
  - platform: nanoleaf
    host: 192.168.1.10
    token: xxxxxxxxxxxxxxxxxxxxx

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Changed from nanoleaf_aurora to nanoleaf
Nanoleaf component now supports both nanoleaf lights, Aurora and Canvas
Changed the dependency to pynanoleaf, nanoleaf does not seem to be
maintained anymore
@fabaff

fabaff approved these changes Mar 11, 2019

@fabaff fabaff merged commit e7c85d3 into home-assistant:dev Mar 11, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.725%
Details

@wafflebot wafflebot bot removed the in progress label Mar 11, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.