Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in LutronButton init if Button doesn't have a type #21921

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
4 participants
@beavis9k
Copy link
Contributor

commented Mar 11, 2019

Description:

RadioRA2 main repeater buttons don't always have ButtonType - this causes an error in LutronButton init. This commit handles that scenario.

Related issue (if applicable): None found, I didn't open one. I can open one if you like.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link

commented Mar 11, 2019

Hi @beavis9k,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@@ -124,7 +124,7 @@ def __init__(self, hass, keypad, button):
"""Register callback for activity on the button."""
name = '{}: {}'.format(keypad.name, button.name)
self._hass = hass
self._has_release_event = 'RaiseLower' in button.button_type
self._has_release_event = button.button_type is not None and 'RaiseLower' in button.button_type

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Mar 11, 2019

line too long (103 > 79 characters)

@homeassistant homeassistant added cla-signed and removed cla-needed labels Mar 11, 2019

@beavis9k beavis9k force-pushed the beavis9k:dev branch from 9be4724 to 72c7f4c Mar 12, 2019

@@ -124,7 +124,8 @@ def __init__(self, hass, keypad, button):
"""Register callback for activity on the button."""
name = '{}: {}'.format(keypad.name, button.name)
self._hass = hass
self._has_release_event = 'RaiseLower' in button.button_type
self._has_release_event = button.button_type is not None and \
'RaiseLower' in button.button_type

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Mar 12, 2019

continuation line over-indented for visual indent

@beavis9k beavis9k force-pushed the beavis9k:dev branch from 72c7f4c to 0aefc3f Mar 12, 2019

@@ -124,7 +124,8 @@ def __init__(self, hass, keypad, button):
"""Register callback for activity on the button."""
name = '{}: {}'.format(keypad.name, button.name)
self._hass = hass
self._has_release_event = 'RaiseLower' in button.button_type
self._has_release_event = button.button_type is not None and \
'RaiseLower' in button.button_type

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Mar 12, 2019

unexpected indentation

@@ -124,7 +124,8 @@ def __init__(self, hass, keypad, button):
"""Register callback for activity on the button."""
name = '{}: {}'.format(keypad.name, button.name)
self._hass = hass
self._has_release_event = 'RaiseLower' in button.button_type
self._has_release_event = button.button_type is not None and \

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Mar 12, 2019

SyntaxError: unexpected character after line continuation character
trailing whitespace

@beavis9k beavis9k force-pushed the beavis9k:dev branch from 0aefc3f to 13c5c8b Mar 12, 2019

@balloob balloob merged commit eed1168 into home-assistant:dev Mar 13, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 92.827%
Details

@ghost ghost removed the in progress label Mar 13, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.