Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusing warning for TTS without entity_id #21927

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@amelchio
Copy link
Member

amelchio commented Mar 11, 2019

Description:

The TTS say service calls media_player.play_media. This PR is to make TTS always pass entity_id in that call, avoiding this confusing warning (that mentions the wrong service call):

2019-03-11 09:28:09 WARNING (MainThread) [homeassistant.helpers.service] Not passing an entity ID to a service to target all entities is deprecated. Update your call to media_player.play_media to be instead: entity_id: all

The TTS call itself should probably have a deprecation warning as well. I think we want some general infrastructure to provide that so I did not add it in this PR.

Related issue (if applicable): fixes #21831

Example entry for configuration.yaml (if applicable):

service: tts.google_say
data:
  message: 'May the Force be with you.'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@pvizeli pvizeli merged commit 49014ac into home-assistant:dev Mar 11, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0003%) to 92.729%
Details

@wafflebot wafflebot bot removed the in progress label Mar 11, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.