Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomeKit controller light - remove code that can never execute #21951

Merged

Conversation

Projects
None yet
3 participants
@Jc2k
Copy link
Contributor

commented Mar 11, 2019

Description:

I have a few changes in my config flow branch that aren't strictly to do with config flow. I'm pulling them into seperate PR's so that the remaining config flow stuff is easier to review.

I've done a lot of work on test coverage via that branch and this PR is a small change I made to get the coverage on light to 100%. The properties do not need to be conditional on self._features because the Light base class actually only inspects these properties when they are supported. This was creating 3x return None branches that were never executed.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost added the in progress label Mar 11, 2019

@balloob balloob merged commit deb66bb into home-assistant:dev Mar 13, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.802%
Details

@ghost ghost removed the in progress label Mar 13, 2019

@Jc2k Jc2k deleted the Jc2k:homekit_controller_light_coverage_bump branch Mar 19, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.