Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection quality related attributes to Homematic IP #21990

Merged
merged 1 commit into from Mar 23, 2019

Conversation

Projects
None yet
3 participants
@SukramJ
Copy link
Contributor

commented Mar 12, 2019

Description:

This PR adds extra attributes to Homematic IP devices to determine connection quality, and helps to identify issues with it.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost added the in progress label Mar 12, 2019

@SukramJ SukramJ changed the title Add signal strength attributes to Homematic IP [RFC] Add signal strength attributes to Homematic IP Mar 12, 2019

@SukramJ SukramJ referenced this pull request Mar 12, 2019

Closed

[RFC] Add sensors for signal strength to Homematic IP #21563

3 of 3 tasks complete

@SukramJ SukramJ changed the title [RFC] Add signal strength attributes to Homematic IP Add signal strength device_state_attributes to Homematic IP Mar 12, 2019

@SukramJ SukramJ changed the title Add signal strength device_state_attributes to Homematic IP Add connection quality related attributes to Homematic IP Mar 22, 2019

@SukramJ

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

Hi @MartinHjelmare,
please have a look at this PR for review.
BR
Markus

@MartinHjelmare MartinHjelmare merged commit 112ed88 into home-assistant:dev Mar 23, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.674%
Details

@ghost ghost removed the in progress label Mar 23, 2019

@SukramJ SukramJ deleted the SukramJ:HmIP-RSSI branch Mar 23, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Mar 27, 2019

Merge branch 'dev' into current
* dev: (99 commits)
  show which component is causing translation errors (home-assistant#22340)
  fix where PLATFORM_SCHEMA gets pulled from (home-assistant#22334)
  Consolidate more platforms (home-assistant#22308)
  Update file header (home-assistant#22318)
  Remove occupancy as it is not available in API (home-assistant#22320)
  Google Assistant: Add camera stream trait (home-assistant#22278)
  Add Freebox switch platform (home-assistant#21710)
  Add homematicip cloud connection quality related attributes (home-assistant#21990)
  Update abbreviation (home-assistant#22317)
  Upgrade py-cpuinfo to 5.0.0 (home-assistant#22287)
  Upgrade pylast to 3.1.0 (home-assistant#22302)
  Fix for embedded MQTT server configuration (home-assistant#22305)
  Switch from using Google Maps API for elevation to Open Elevation API (home-assistant#22306)
  Update srpenergy library (home-assistant#22307)
  Sort code owners alphabetically (home-assistant#22304)
  Update trait to support auto without ranges. (home-assistant#21847)
  Fix Prometheus casting issues (home-assistant#22282)
  Add sort by config and tests for Reddit integration (home-assistant#22081)
  Fix progress for Plex media_players (home-assistant#22224)
  Fixing the api_streams sensor (home-assistant#22200)
  ...

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.