Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for Sonos regrouping in service calls #22006

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@amelchio
Copy link
Member

amelchio commented Mar 13, 2019

Description:

This PR makes the Sonos join/unjoin/restore service calls block until the target group topology has been confirmed by a UPnP event from the speaker. The change makes the operations better suited for scripts because carefully applied delay: steps are no longer needed.

Example entry for configuration.yaml (if applicable):

The following script:

  sonos_shuffle:
    sequence:
      - service: media_player.sonos_join
        data:
          master: media_player.any
      - service: media_player.sonos_unjoin
      - service: media_player.media_pause
        entity_id: all

without this PR produces logs like these:

2019-03-13 12:25:39 ERROR (SyncWorker_2) [homeassistant.components.sonos.media_player] Error on media_pause with The method or property "pause" can only be called/used on the coordinator in a group

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Mar 13, 2019

@balloob balloob merged commit de2c7a9 into home-assistant:dev Mar 13, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA

@wafflebot wafflebot bot removed the in progress label Mar 13, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.