Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whois error, check updated_date for list and pick first #22008

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@GGeezes
Copy link
Contributor

commented Mar 13, 2019

Description:

Check the whois response type for updated_date to avoid Attribute errors due to calling isoformat() on a list.
Now takes the first element of the list, this may not always be correct but from the response there is no way to determine what the elements of the list are. (

Related issue (if applicable): fixes #22007

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

 26 # Sensors                                                                       
 27 sensor:                                                                         
 28   # Weather prediction                                                          
 29   - platform: yr                                                                
 30                                                                                 
 31   - platform: whois                                                             
 32     domain: google.com                                                          
 33                                                                                 
 34   - platform: whois                                                             
 35     domain: apple.com  

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost added the in progress label Mar 13, 2019

@GGeezes GGeezes changed the title Check updated_date for list and pick first Fix whois error, check updated_date for list and pick first Mar 13, 2019

@balloob balloob merged commit 1ffc0e3 into home-assistant:dev Mar 13, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 92.829%
Details

@ghost ghost removed the in progress label Mar 13, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.