Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temp unit assumption from SmartThings Sensor platform #22012

Merged

Conversation

Projects
None yet
3 participants
@andrewsayre
Copy link
Member

commented Mar 13, 2019

Description:

Removes the default temperature unit for attributes that officially define no default unit in the SmartThings Capability reference. This ensures we display no unit when the unit is not populated by devices not properly implementing capabilities instead of making an assumption and potentially displaying the wrong unit/converted value.

Related issue (if applicable): fixes #22009

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost assigned andrewsayre Mar 13, 2019

@ghost ghost added the in progress label Mar 13, 2019

@balloob balloob merged commit 83243e9 into home-assistant:dev Mar 13, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on fix-smartthings-sensor-temp-unit at 92.829%
Details

@ghost ghost removed the in progress label Mar 13, 2019

@andrewsayre andrewsayre deleted the andrewsayre:fix-smartthings-sensor-temp-unit branch Mar 13, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.