Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the boiler status #22021

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
7 participants
@cgtobi
Copy link
Collaborator

commented Mar 14, 2019

Description:

In the past the state returned whether the the device was heating or idle. Now the state returns the operation mode which can be auto, manual, etc. and is a different thing.

The boiler_status attribute returned the operation mode which has changed to the actual mode not the state of the boiler.
This PR brings back the actual boiler status.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added in progress and removed cla-signed labels Mar 14, 2019

@cgtobi cgtobi marked this pull request as ready for review Mar 14, 2019

@awarecan

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

Off-topic, why we still have a boiler hide in climate component?

@shanbs

shanbs approved these changes Mar 14, 2019

Copy link
Contributor

left a comment

Important bug fix, should be merged.

@shanbs

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

Off-topic, why we still have a boiler hide in climate component?

Many heating systems do have a boiler.

@awarecan

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

We have water_heater component designed for this purpose. And I thought we already moved all of those devices to water_heater

@shanbs

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

As the name indicates, I think it is for water heater, not the house heating system. A house heating does not have minimal temperature, maximum temperature setting, usually. Instead, it should have target temperature, current temperature, etc. So at least for the moment, climate is more suitable for such a heating system.

@cgtobi

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 14, 2019

This is no water heater and a fundamental part of a heating system, so in my opinion it is perfectly valid to keep this as a property.

See the Netatmo API documentation, they expose for a reason.
https://dev.netatmo.com/resources/technical/reference/energy/homestatus

@awarecan

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

OK, I see.

@balloob balloob added this to the 0.90.0 milestone Mar 14, 2019

@balloob balloob merged commit 018a5d5 into home-assistant:dev Mar 14, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 92.823%
Details

@ghost ghost removed the in progress label Mar 14, 2019

@cgtobi cgtobi deleted the cgtobi:patch-3 branch Mar 14, 2019

balloob added a commit that referenced this pull request Mar 14, 2019

@colsonpete

This comment has been minimized.

Copy link

commented Mar 20, 2019

A reason for needing boiler status (I think!)...
I have a Netatmo Thermostat. I have a stand-alone CH pump which is necessary for a new underfloor heating circult in a recently added extension. But how do I control it? For the last couple of years I have used a separate wireless thermostat connected to a boiler control which simply turns the pump on and off depending on the room temperature. It would be far better to be able to interrogate the Netatmo Thermostat and if it is calling for heat, turn the pump on, if not calling for heat, turn pump off. This is the prime reason I recently started my Hass.io project.

Having access to a property that tells me whether or not the netatmo thermostat is calling for heat (e.g. blue light on at base unit) is exactly what I need! Please bring it back!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

It is back since this PR is merged.

For more discussion see below.

If you want to suggest an enhancement please open a feature request in the Feature Requests section of our community forum.

Merged PRs should not be used for enhancement discussion or bug reports. If you've found a bug it's ok to make a review with inline comments and link to an issue that reports the bug.

Thanks!

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Mar 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.