Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lifx light async error #22031

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
5 participants
@awarecan
Copy link
Contributor

awarecan commented Mar 14, 2019

Description:

extract_entity_ids changed implementation in #21472, need change the caller code if caller is a coroutine.

We have only 4 components still called extract_entity_ids.
nuki, onvif, and neato all okay since those callers are not coroutine.

However the caller in lifx light is called by a coroutine, it has to be change to call async_extract_entity_ids

Related issue (if applicable): fixes #22026

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@cdheiser

This comment has been minimized.

Copy link
Contributor

cdheiser commented Mar 14, 2019

I have patched my instance and LIFX service calls now work properly

@amelchio
Copy link
Member

amelchio left a comment

Thanks, awesome PR description 👍

@amelchio amelchio added this to the 0.90.0 milestone Mar 14, 2019

@amelchio amelchio merged commit e480f75 into home-assistant:dev Mar 14, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 92.825%
Details

@wafflebot wafflebot bot removed the in progress label Mar 14, 2019

balloob added a commit that referenced this pull request Mar 14, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.