Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telegram_bot: Allow fetching data from unverified SSL endpoints (#22067) #22069

Merged

Conversation

Projects
None yet
5 participants
@nbarrientos
Copy link
Contributor

commented Mar 15, 2019

Description:

This patch adds an extra option to the payload that describes the resource to send to disable the SSL server verification when polling data from URLs. This could be useful when downloading content from endpoints in the LAN with self-signed certificates that only expose a SSL entrypoint. The original behaviour if not set is kept.

Related issue: fixes #22067

Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#8950

Example entry for configuration.yaml

action:
  service: notify.NOTIFIER_NAME
  data:
    title: Send an image
    message: "That's an example that sends an image."
    data:
      photo:
        - url: https://192.168.1.28/camera.jpg
          username: admin
          password: secrete
          verify_ssl: false

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.
  • Documentation added/updated in home-assistant.io
  • Tests have been added to verify that the new code works.

This is a PoC that has not been tested locally yet. I will be happy to increase the test coverage and contribute to the documentation if the change proposal goes through.

Thanks for reviewing!

Telegram_bot: Allow fetching data from unverified SSL endpoints (#22067)
This patch adds an extra option to the payload that describes the
resource to send to disable the SSL server verification when polling
data from URLs.
@homeassistant

This comment has been minimized.

Copy link

commented Mar 15, 2019

Hi @nbarrientos,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Use the boolean interpretation of the variable directly
Co-Authored-By: nbarrientos <nacho@criptonita.com>
@cgtobi

cgtobi approved these changes Mar 15, 2019

Copy link
Collaborator

left a comment

LGTM

@nbarrientos

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

Thanks for the review. I will prepare the patch for the documentation.

@rohankapoorcom rohankapoorcom merged commit 4226503 into home-assistant:dev Mar 16, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on telegram_bot_verify_ssl at 92.77%
Details

@ghost ghost removed the in progress label Mar 16, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.