Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add available property to Ambient PWS #22092

Merged
merged 3 commits into from Mar 16, 2019

Conversation

Projects
None yet
3 participants
@bachya
Copy link
Contributor

commented Mar 15, 2019

Description:

The Ambient Weather websocket only returns the data that it receives; this means that it's possible for sensors to become unavailable. This PR adds logic to render then unavailable, rather than removing them from the UI.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

ambient_station:
  api_key: !secret ambient_api_key
  app_key: !secret ambient_app_key

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

bachya and others added some commits Mar 15, 2019

@ghost ghost assigned Danielhiversen Mar 16, 2019

@Danielhiversen Danielhiversen merged commit 7807b40 into home-assistant:dev Mar 16, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.008%) to 92.775%
Details

@ghost ghost removed the in progress label Mar 16, 2019

@bachya bachya deleted the bachya:ambient-availability branch Mar 17, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.