Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError traceback with darksky #22101

Merged
merged 2 commits into from Mar 17, 2019

Conversation

Projects
None yet
4 participants
@iamtpage
Copy link
Contributor

commented Mar 16, 2019

Description:

When self.data is None, returning self.data.get('flags').get('units') fails with an AttributeError

Related issue (if applicable): fixes #20596

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

weather:
  - platform: darksky
    api_key: !secret darksky_api
    mode: hourly
    name: "Hourly Forecast"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@fabaff

fabaff approved these changes Mar 17, 2019

Comment addressed

@fabaff fabaff merged commit 9b1491a into home-assistant:dev Mar 17, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on patch-2 at 92.775%
Details

@ghost ghost removed the in progress label Mar 17, 2019

@iamtpage iamtpage deleted the iamtpage:patch-2 branch Mar 17, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

@iamtpage iamtpage referenced this pull request May 3, 2019

Merged

Fix iterating over NoneType exception #23648

3 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.