Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle occassional 502 Bad Gateway from SimpliSafe #22131

Merged
merged 1 commit into from Mar 17, 2019

Conversation

Projects
None yet
2 participants
@bachya
Copy link
Contributor

commented Mar 17, 2019

Description:

Every now an again, SimpliSafe sends back a 502; it doesn't cause any further issues (i.e., the component will merely try again later), but it leaves an unsightly exception in the logs. This PR handles logging the error.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): N.A

Example entry for configuration.yaml (if applicable):

simplisafe:
  accounts:
    - username: !secret simplisafe_username
      password: !secret simplisafe_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@bachya bachya self-assigned this Mar 17, 2019

@ghost ghost added the in progress label Mar 17, 2019

@bachya bachya merged commit 0d42ed1 into home-assistant:dev Mar 17, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.002%
Details

@ghost ghost removed the in progress label Mar 17, 2019

@bachya bachya deleted the bachya:simplipy-error branch Mar 17, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.