Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace einder lib with horimote #22135

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
4 participants
@benleb
Copy link
Contributor

commented Mar 17, 2019

Description:

Unitymedia Germany changed the port and XML filename which is used by the horizon component to check the online/available state. As the original maintainer of the used einder lib does not want to maintain it anymore (i talked to him, he does also not use it anymore), it is replaced by horimote. Horimote is a einder fork with updated port and filename.

Related issue (if applicable): Horizon cannot detect state and allows no device control.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@cgtobi

cgtobi approved these changes Mar 17, 2019

Copy link
Collaborator

left a comment

LGTM

@fabaff

fabaff approved these changes Mar 18, 2019

@fabaff fabaff merged commit af473cd into home-assistant:dev Mar 18, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 92.999%
Details

@ghost ghost removed the in progress label Mar 18, 2019

@fabaff fabaff changed the title replace einder lib with horimote Replace einder lib with horimote Mar 18, 2019

@benleb benleb deleted the benleb:change-einder-to-horimote branch Mar 18, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.