Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional sensors and fixed icons, attributes and device classes. #22139

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
3 participants
@endor-force
Copy link
Contributor

commented Mar 17, 2019

Description:

  • Use updated package version of pytrafikverket from 0.1.5.8 to 0.1.5.9.
  • Added additional sensors precipitation_amount and precipitation_amountname.
  • Added attributes: active, measure_time and attribution to the sensor component.
  • Added relevant default icons to the sensors.

Related issue (if applicable): fixes #17643

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8970

Example entry for configuration.yaml (if applicable):

  - platform: trafikverket_weatherstation
    name: Kullebo
    api_key: !secret trafikverket_api
    station: Kullebo
    monitored_conditions:
     - air_temp
     - road_temp
     - humidity
     - precipitation
     - wind_direction
     - wind_direction_text
     - wind_speed
     - precipitation_amount
     - precipitation_amountname

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@fabaff

fabaff approved these changes Mar 18, 2019

@fabaff fabaff merged commit 9f96aab into home-assistant:dev Mar 18, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.002%
Details

@ghost ghost removed the in progress label Mar 18, 2019

@endor-force endor-force deleted the endor-force:trafikverket_upgrade branch Mar 24, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.