Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ATTR_BATTERY_STATE_UNPLUGGED for ios component #22152

Merged
merged 2 commits into from Mar 19, 2019

Conversation

Projects
None yet
5 participants
@FattusMannus
Copy link
Contributor

FattusMannus commented Mar 18, 2019

Description:

Improved Text description of ATTR_BATTERY_STATE_UNPLUGGED from Unplugged to Not Charging as many new iOS devices now use Wireless charging and there is no concept of "Plugging In"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@FattusMannus FattusMannus requested a review from robbiet480 as a code owner Mar 18, 2019

@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Mar 18, 2019

Hi @FattusMannus,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@awarecan

This comment has been minimized.

Copy link
Contributor

awarecan commented Mar 18, 2019

Although it is small change, it may still break someone's automation, so I put a breaking changes label.

Any translation need change?

@FattusMannus

This comment has been minimized.

Copy link
Contributor Author

FattusMannus commented Mar 18, 2019

Cant see any translations that would need updating.
However, ive just seen this in device_tracker:

"battery_status": 'Unplugged',

Do you think my chsnge could cause a side effect here?

EDIT: It seems to be in tests only, and these pass so im not concerned

@awarecan

This comment has been minimized.

Copy link
Contributor

awarecan commented Mar 18, 2019

I will prefer changing the test as well.

@FattusMannus

This comment has been minimized.

Copy link
Contributor Author

FattusMannus commented Mar 18, 2019

Test updated

@awarecan awarecan changed the title AH - Updated Text Description of ATTR_BATTERY_STATE_UNPLUGGED Change ATTR_BATTERY_STATE_UNPLUGGED for ios component Mar 19, 2019

@awarecan awarecan merged commit 12df14b into home-assistant:dev Mar 19, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0004%) to 93.003%
Details

@wafflebot wafflebot bot removed the in progress label Mar 19, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

@jayscovill

This comment has been minimized.

Copy link

jayscovill commented Apr 18, 2019

Did this actually make it into the release? My iPhone is still showing "unplugged".

@FattusMannus

This comment has been minimized.

Copy link
Contributor Author

FattusMannus commented Apr 18, 2019

@awarecan

This comment has been minimized.

Copy link
Contributor

awarecan commented Apr 18, 2019

It is in.
image

Open a new issue if it did not work

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Apr 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.