Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic subscription for ZHA add device page #22164

Merged
merged 12 commits into from Mar 19, 2019

Conversation

Projects
None yet
4 participants
@dmulcahey
Copy link
Contributor

commented Mar 18, 2019

Description:

This PR adds the backend support for the new add devices page. It leverages the new subscription functionality for the frontend.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

ezgif-2-10950199fe8b

Front end PR: home-assistant/home-assistant-polymer#2969

dmulcahey added some commits Mar 10, 2019

@Adminiuga
Copy link
Contributor

left a comment

Looks good.


entry = LogEntry(record, stack,
_figure_out_source(record, stack, self.hass))
async_dispatcher_send(

This comment has been minimized.

Copy link
@balloob

balloob Mar 19, 2019

Member

Is all logging done from async contexts? If not, you will need to check here if your function is inside the loop or not.

This comment has been minimized.

Copy link
@dmulcahey

dmulcahey Mar 19, 2019

Author Contributor

Can you expand on this a bit? Do you have an example I can peek at? I’m assuming there is some sort of check, and if in loop use this else use regular dispatcher_send? I haven’t seen any issues... but that doesn’t mean this is correct either.

This comment has been minimized.

Copy link
@Adminiuga

Adminiuga Mar 19, 2019

Contributor

Zigpy, bellows, zigpy-deconz and zigpy-xbee all run in event loop. ZHA platform as well. I don't think we have anything sync running.

This comment has been minimized.

Copy link
@dmulcahey

dmulcahey Mar 19, 2019

Author Contributor

that was my thought... but I can't guarantee everything is perfect.

@Adminiuga Adminiuga merged commit 46ece36 into home-assistant:dev Mar 19, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 93.014%
Details

@ghost ghost removed the in progress label Mar 19, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

@dmulcahey dmulcahey deleted the dmulcahey:dm/zha-dynamic-logging branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.