Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed overly broad exception handling for nanoleaf light #22189

Merged

Conversation

Projects
None yet
3 participants
@Oro
Copy link
Contributor

commented Mar 19, 2019

Description:

Instead of checking for all exceptions, check for the concrete exception in case the light is unavailable and let the library handle the rest.
If the import inside update() is bad form I'd welcome alternatives!
(see also comment on #21945 )

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost added the in progress label Mar 19, 2019

@balloob balloob merged commit ab17b22 into home-assistant:dev Mar 21, 2019

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
coverage/coveralls Coverage increased (+0.002%) to 93.686%
Details

@ghost ghost removed the in progress label Mar 21, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

A lot better! Thanks.

It's not bad form, because of how our requirements work, that is how we roll.

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.