Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ZHA channel name property #22218

Merged
merged 2 commits into from Mar 21, 2019

Conversation

Projects
None yet
5 participants
@Adminiuga
Copy link
Contributor

commented Mar 20, 2019

Description:

Minor refactoring of ZHA channels. Tie ZHA channel name more closely to their corresponding ZCL Cluster name in zigpy.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost assigned Adminiuga Mar 20, 2019

@ghost ghost added the in progress label Mar 20, 2019

@Adminiuga Adminiuga force-pushed the Adminiuga:ac/zha-channel-name-prop branch from 2c2e127 to 4e3f821 Mar 20, 2019

@Adminiuga Adminiuga requested a review from dmulcahey Mar 20, 2019

@Adminiuga Adminiuga force-pushed the Adminiuga:ac/zha-channel-name-prop branch from 4e3f821 to 45ea3e4 Mar 20, 2019

Cleanup Zigbee channels.
Use zcl.Cluster.ep_attribute as default channel name.

@Adminiuga Adminiuga force-pushed the Adminiuga:ac/zha-channel-name-prop branch 2 times, most recently from f7ba452 to e480f27 Mar 20, 2019

@Adminiuga Adminiuga closed this Mar 20, 2019

@Adminiuga Adminiuga reopened this Mar 20, 2019

@ghost ghost added in progress and removed in progress labels Mar 20, 2019

@balloob balloob merged commit 03855c1 into home-assistant:dev Mar 21, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 93.682%
Details

@ghost ghost removed the in progress label Mar 21, 2019

@Adminiuga Adminiuga deleted the Adminiuga:ac/zha-channel-name-prop branch Mar 21, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.