Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Season sensor local time offset #22233

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
3 participants
@rdbahm
Copy link
Contributor

commented Mar 21, 2019

Description:

Discovered today during the season change that the Season sensor does not change at the correct time in my time zone - this is because ephem works in UTC time, not local time. Since the sensor was comparing UTC to local, it ended up 7 hours off of the actual official change. This is a very simple change to correct this behavior.

Related issue (if applicable): No related issue.

Pull request in home-assistant.io with documentation (if applicable): No related documentation changes.

Example entry for configuration.yaml (if applicable):

No new configuration needed.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Change .now() to .utcnow()
ephem works in UTC time, not local time. As a result, our comparison needs to be in UTC for accurate results.

@ghost ghost added the in progress label Mar 21, 2019

@rdbahm rdbahm changed the title Change .now() to .utcnow() Fix Season sensor local time offset Mar 21, 2019

@balloob balloob merged commit bc85d47 into home-assistant:dev Mar 21, 2019

3 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ghost ghost removed the in progress label Mar 21, 2019

@rdbahm rdbahm deleted the rdbahm:season-utc branch Mar 21, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.