Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plex: Avoid refreshing by both device and session methods #22266

Merged
merged 2 commits into from Mar 22, 2019

Conversation

Projects
None yet
5 participants
@jjlawren
Copy link
Contributor

commented Mar 21, 2019

Description:

Some Plex clients would be refreshed twice during each poll if the include_non_clients parameter was set, adding unnecessary overhead.

Example entry for configuration.yaml (if applicable):

media_player:
    - platform: plex
      include_non_clients: true

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob merged commit 30d4a9f into home-assistant:dev Mar 22, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on plex_avoid_double_refresh at 93.674%
Details

@ghost ghost removed the in progress label Mar 22, 2019

@jjlawren jjlawren deleted the jjlawren:plex_avoid_double_refresh branch Mar 22, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.