Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Assistant: Add camera stream trait #22278

Merged
merged 2 commits into from Mar 23, 2019

Conversation

Projects
None yet
5 participants
@balloob
Copy link
Member

commented Mar 22, 2019

Description:

Add support for the Camera Stream trait to Google Assistant: https://developers.google.com/actions/smarthome/traits/camerastream

Demos here: https://photos.google.com/share/AF1QipODO6tTPeOfI41itmt1PlxgecpxhZIOf5HKiyy0Z-AIkDlKzAd18aM0pzsvo5mBlQ?key=Tk5YM3Vtal9LTHg1Wmk5Z2FfbFJfRXoxcUh0NUtB

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@hunterjm
Copy link
Contributor

left a comment

This is awesome!

Show resolved Hide resolved homeassistant/components/camera/__init__.py Outdated
@pergolafabio

This comment has been minimized.

Copy link

commented Mar 22, 2019

Just a question between, if you make new development for Google assistant, is it both the same time for local and nabu casa component?

@balloob

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

@pergolafabio correct, they share the same code base.

@pergolafabio

This comment has been minimized.

Copy link

commented Mar 22, 2019

Ok , thnx strange, I have issues with nabucasa edition, same scripts are giving error on nabucasa and working well on Google local edition... But already opened a support ticket for it on nabucasa

@balloob

This comment has been minimized.

Copy link
Member Author

commented Mar 23, 2019

Merging this so we can play with it in dev 😁

@balloob balloob merged commit c68b621 into dev Mar 23, 2019

10 checks passed

Hound No violations found. Woof!
Python 3.5 - lints Python 3.5 - lints
Details
Python 3.5 - tests Python 3.5 - tests
Details
Python 3.6 - tests Python 3.6 - tests
Details
Python 3.7 - tests Python 3.7 - tests
Details
Pyton 3.5 - typing Pyton 3.5 - typing
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 93.674%
Details

@ghost ghost removed the in progress label Mar 23, 2019

@delete-merged-branch delete-merged-branch bot deleted the add-camera-stream-trait branch Mar 23, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Mar 27, 2019

Merge branch 'dev' into current
* dev: (99 commits)
  show which component is causing translation errors (home-assistant#22340)
  fix where PLATFORM_SCHEMA gets pulled from (home-assistant#22334)
  Consolidate more platforms (home-assistant#22308)
  Update file header (home-assistant#22318)
  Remove occupancy as it is not available in API (home-assistant#22320)
  Google Assistant: Add camera stream trait (home-assistant#22278)
  Add Freebox switch platform (home-assistant#21710)
  Add homematicip cloud connection quality related attributes (home-assistant#21990)
  Update abbreviation (home-assistant#22317)
  Upgrade py-cpuinfo to 5.0.0 (home-assistant#22287)
  Upgrade pylast to 3.1.0 (home-assistant#22302)
  Fix for embedded MQTT server configuration (home-assistant#22305)
  Switch from using Google Maps API for elevation to Open Elevation API (home-assistant#22306)
  Update srpenergy library (home-assistant#22307)
  Sort code owners alphabetically (home-assistant#22304)
  Update trait to support auto without ranges. (home-assistant#21847)
  Fix Prometheus casting issues (home-assistant#22282)
  Add sort by config and tests for Reddit integration (home-assistant#22081)
  Fix progress for Plex media_players (home-assistant#22224)
  Fixing the api_streams sensor (home-assistant#22200)
  ...

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

@mariuszluciow

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

@balloob docs are missing https://www.home-assistant.io/components/google_assistant/ camera is not listed in supported domains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.