Google assistant: add blinds trait for covers #22336
Conversation
ghost
added
the
|
i am wondering if you can also initiate a STOP command? |
|
Looks like there are some test issues. |
|
@pergolafabio no the trait doesn't support it I'm trying to fix it to pass tests. It's the first time I contribute to a project on github. My modification was working well in my environment, I thought it would be easier to submit it. |
awarecan
removed request for
robbiet480,
bachya,
fabaff,
dgomes,
Danielhiversen,
dmulcahey,
syssi,
rytilahti,
andrey-git,
Adminiuga,
andrewsayre,
ludeeus,
Kane610 and
cdce8p
|
Looks great ! I will tag it for 0.91 so that people can start using it faster 👍 Marked it as a breaking change because people have to use different voice commands now to control their covers. |
* Update const.py * Update smart_home.py * Update trait.py * Update test_trait.py * Update smart_home.py * Update test_trait.py * Update trait.py * Update trait.py * Update test_trait.py * Update test_trait.py * Update __init__.py * Update test_trait.py * Change email * Trying to correct CLA * Update __init__.py * Update trait.py * Update trait.py * Update trait.py * Update trait.py * Update __init__.py * Update test_trait.py * Update test_google_assistant.py * Update trait.py * Update trait.py * Update test_trait.py * Update test_trait.py
|
@balloob I was happy to use this today, but noticed that the list of supported domains in the docs needs to be updated to reflect that it's no longer using brightness: https://www.home-assistant.io/components/google_assistant/ |
|
So did you try it already? What alternative words can you say for open/close? |
|
@pergolafabio Yeah, we're pretty used to saying open and close so that's all we say. You can also say "Hey Google! Set the kitchen shade to 50%." and it will say "Ok, opening the kitchen shade to 50%". |
|
i was hoping you could also say up/down , we dont use those open/close in dutch language :) |
|
@pergolafabio "open/sluit de zonnewering" is pretty natural for me, and even "doe de zonnewering omhoog" worked fine. @giefca is there a way so it also works from the Google Home app? |
|
@michaelarnauts ah ok interesting , so "zonnewering omhoog" "zonnewering omlaag" is working? |
|
Chat on the forums please 👍 |
Description:
Add support for the Blinds Trait to Google Assistant:
https://developers.google.com/actions/smarthome/traits/openclose
Covers use the blinds trait instead of the onoff and brightness trait. Voice commands are more naturals.
The only downside is that we lose the ability to control covers within the Google Home App.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: