Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn user about HTML5 GCM deprecation #22351

Merged
merged 4 commits into from Mar 25, 2019
Merged

Warn user about HTML5 GCM deprecation #22351

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d81ce5b
Warn user about GCM deprecation
hmmbob Mar 24, 2019
19073c1
Fixing hound
hmmbob Mar 24, 2019
6116ae5
Fixing typo
hmmbob Mar 24, 2019
447db33
Fixing Travis fail
hmmbob Mar 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 15 additions & 1 deletion homeassistant/components/notify/html5.py
View file
Open in desktop
Expand Up @@ -45,8 +45,22 @@
ATTR_VAPID_PRV_KEY = 'vapid_prv_key'
ATTR_VAPID_EMAIL = 'vapid_email'


def gcm_api_deprecated(value):
hmmbob marked this conversation as resolved.
Show resolved Hide resolved
"""Warn user that GCM API config is deprecated."""
if not value:
return value

_LOGGER.warning(
"Configuring html5_push_notifications via the GCM api"
" has been deprecated and will stop working after April 11,"
" 2019. Use the VAPID configuration instead. For instructions,"
" see https://www.home-assistant.io/components/notify.html5/")
return value

PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({
vol.Optional(ATTR_GCM_SENDER_ID): cv.string,
vol.Optional(ATTR_GCM_SENDER_ID):
vol.All(cv.string, gcm_api_deprecated),
vol.Optional(ATTR_GCM_API_KEY): cv.string,
vol.Optional(ATTR_VAPID_PUB_KEY): cv.string,
vol.Optional(ATTR_VAPID_PRV_KEY): cv.string,
Expand Down