Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for yeelight availbility state #22502

Merged
merged 2 commits into from Mar 29, 2019

Conversation

Projects
None yet
4 participants
@zewelor
Copy link
Contributor

commented Mar 28, 2019

Description:

Fix availability state update, after migration to component. Also fix log spam when light is anavailable

Related issue (if applicable): fixes #22495

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@zewelor zewelor requested a review from rytilahti as a code owner Mar 28, 2019

@ghost ghost added the in progress label Mar 28, 2019

@syssi syssi added this to the 0.91.0 milestone Mar 28, 2019

@zewelor zewelor force-pushed the zewelor:fix_yeelight_availbility_state branch from 9269dcb to b588db2 Mar 28, 2019

if temp_in_k:
self._color_temp = kelvin_to_mired(int(temp_in_k))
if self._is_nightlight_enabled:
bright = self._get_property('nl_br', None)

This comment has been minimized.

Copy link
@syssi

syssi Mar 28, 2019

Member

The default of _get_property is None by "default". The second parameter isn't needed.

if self._is_nightlight_enabled:
bright = self._get_property('nl_br', None)
else:
bright = self._get_property('bright', None)

This comment has been minimized.

Copy link
@syssi

syssi Mar 28, 2019

Member

Same here.

This comment has been minimized.

Copy link
@zewelor

zewelor Mar 28, 2019

Author Contributor

Fixed

@syssi

syssi approved these changes Mar 28, 2019

@zewelor zewelor force-pushed the zewelor:fix_yeelight_availbility_state branch from 94575f4 to 1ae6949 Mar 28, 2019

@syssi syssi closed this Mar 29, 2019

@syssi syssi reopened this Mar 29, 2019

@ghost ghost removed the in progress label Mar 29, 2019

@ghost ghost assigned syssi Mar 29, 2019

@ghost ghost added the in progress label Mar 29, 2019

zewelor added some commits Mar 28, 2019

@zewelor zewelor force-pushed the zewelor:fix_yeelight_availbility_state branch from 1ae6949 to 328cabf Mar 29, 2019

@syssi syssi merged commit 4e78d89 into home-assistant:dev Mar 29, 2019

6 checks passed

Hound No violations found. Woof!
ci/circleci: build Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on fix_yeelight_availbility_state at 93.34%
Details
workflow Workflow: workflow
Details

@ghost ghost removed the in progress label Mar 29, 2019

balloob added a commit that referenced this pull request Mar 29, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.