Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use zha default light polling #22513

Merged
merged 2 commits into from Mar 29, 2019

Conversation

@dmulcahey
Copy link
Contributor

commented Mar 29, 2019

Description:

Fixes a nasty bug in ZHA lights.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@dmulcahey dmulcahey requested a review from Adminiuga as a code owner Mar 29, 2019

@ghost ghost assigned dmulcahey Mar 29, 2019

@ghost ghost added the in progress label Mar 29, 2019

@dmulcahey dmulcahey added this to the 0.91.0 milestone Mar 29, 2019

@MartinHjelmare MartinHjelmare changed the title don't use default light polling Do not use zha default light polling Mar 29, 2019

Show resolved Hide resolved homeassistant/components/zha/light.py Outdated

@dmulcahey dmulcahey requested a review from MartinHjelmare Mar 29, 2019

@Adminiuga
Copy link
Contributor

left a comment

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit 6dc1277 into home-assistant:dev Mar 29, 2019

4 of 5 checks passed

ci/circleci: Build Error Your tests failed on CircleCI
Details
Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on dm/zha-debug at 93.37%
Details

@ghost ghost removed the in progress label Mar 29, 2019

balloob added a commit that referenced this pull request Mar 29, 2019

Do not use zha default light polling (#22513)
* don't use default light polling

* review comment

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

@dmulcahey dmulcahey deleted the dmulcahey:dm/zha-debug branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.