Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tts Great Migration issue #22539

Merged
merged 1 commit into from Mar 29, 2019

Conversation

@awarecan
Copy link
Contributor

commented Mar 29, 2019

Description:

Add __init__.py to several tts integrations

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@awarecan

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

It seems the circleci won't start on my PR. Maybe cause by I enabled circleci on my fork repo.

@awarecan awarecan force-pushed the awarecan:fix-tts branch from 4ca2baa to 49c7f04 Mar 29, 2019

@awarecan

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

So, it looks like a circleci/github bug, after I force-pushed, the circleci build status displayed and it points to my repo's CI build status.

@balloob balloob merged commit c31ab7a into home-assistant:dev Mar 29, 2019

2 of 4 checks passed

ci/circleci: build CircleCI is running your tests
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA

@ghost ghost removed the in progress label Mar 29, 2019

@awarecan awarecan deleted the awarecan:fix-tts branch Mar 29, 2019

balloob added a commit that referenced this pull request Mar 29, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.