Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name conflict in tests #22556

Merged
merged 3 commits into from Mar 30, 2019

Conversation

Projects
None yet
4 participants
@awarecan
Copy link
Contributor

commented Mar 30, 2019

Description:

Fix failing tests in circleci. config_entries.HANDLERS is a global variable. To ensure the isolation of tests, we need to make sure each test config flow has unique names.

It failed in circleci but not travis because we changed the execution order of tests.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned awarecan Mar 30, 2019

@ghost ghost added the in progress label Mar 30, 2019

@awarecan awarecan force-pushed the fix-test branch from ece0b7e to d10b0db Mar 30, 2019

@awarecan awarecan force-pushed the fix-test branch from d10b0db to 2001818 Mar 30, 2019

@awarecan awarecan merged commit 6430692 into dev Mar 30, 2019

20 checks passed

Hound No violations found. Woof!
Python 3.5 - lints Python 3.5 - lints
Details
Python 3.5 - tests Python 3.5 - tests
Details
Python 3.6 - tests Python 3.6 - tests
Details
Python 3.7 - tests Python 3.7 - tests
Details
Pyton 3.5 - typing Pyton 3.5 - typing
Details
build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.967%
Details

@ghost ghost removed the in progress label Mar 30, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-test branch Mar 30, 2019

@awarecan awarecan added this to the 0.91.0 milestone Mar 30, 2019

balloob added a commit that referenced this pull request Apr 1, 2019

Fix name conflict in tests (#22556)
* Fix name conflict in tests

* Lint

* Lint

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.