Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis - support stream #22593

Merged
merged 2 commits into from Apr 5, 2019

Conversation

Projects
None yet
4 participants
@Kane610
Copy link
Contributor

commented Mar 31, 2019

Breaking Change:

Description:

Related issue (if applicable): fixes #

Example entry for configuration.yaml (if applicable):

stream:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Kane610 Kane610 changed the title Axis - support stream WIP: Axis - support stream Apr 1, 2019

@hunterjm hunterjm referenced this pull request Apr 5, 2019

Merged

Fix stream for some cameras #22747

3 of 3 tasks complete
@Kane610

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

Verified to work with #22747

@Kane610 Kane610 changed the title WIP: Axis - support stream Axis - support stream Apr 5, 2019

@Kane610 Kane610 marked this pull request as ready for review Apr 5, 2019

Kane610 added some commits Mar 31, 2019

@Kane610 Kane610 force-pushed the Kane610:axis-support-stream branch from 7eeef7c to 1db811c Apr 5, 2019

@Kane610 Kane610 merged commit 008b641 into home-assistant:dev Apr 5, 2019

11 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA

@ghost ghost removed the in progress label Apr 5, 2019

@Kane610 Kane610 deleted the Kane610:axis-support-stream branch Apr 5, 2019

@balloob balloob modified the milestone: 0.91.2 Apr 5, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Wanted to get this in the release but cannot be cherry picked into rc branch without merge conflicts. So 92 it is.

@Kane610

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

I could create a second pr?

@Kane610

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

Nvm lets just wait for next release

unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019

Axis - support stream (home-assistant#22593)
* Add support for new stream component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.